daru dependency as >= 0.2.0, change version to 0.1.1#79
Open
Yuki-Inoue wants to merge 1 commit intoSciRuby:masterfrom
Yuki-Inoue:fix-dependency-version
Open
daru dependency as >= 0.2.0, change version to 0.1.1#79Yuki-Inoue wants to merge 1 commit intoSciRuby:masterfrom Yuki-Inoue:fix-dependency-version
Yuki-Inoue wants to merge 1 commit intoSciRuby:masterfrom
Yuki-Inoue:fix-dependency-version
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In response to #78 (comment) , making this PR.
In my second thought, I thought it would be better if we lower bound the dependency version, instead of using
~>constraint.Reason is that since the release frequency of Daru and Daru-io seems to be different, using
~>constraint makes it cumbersome to manage the dependency in of this project. Instead, I thought it would be better if we simply just use the lower bound.Any opinion?