Replaced including venv/ directory with requirements.txt #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cloning the
ScorchingShade/Encryptorrepository, 32 out of 38MB of disk space used are from thevenv/directory.Generally, it is best practice to exclude virtual environment directories from repositories, as discussed here and here. Thus, I've replaced the
venv/directory with arequirements.txtfile as described here.I also noticed that the virtual environment does not include
progress, which you importBarfrom. This results in anImportErrordue toprogressnot being installed. I found thatprogresswasn't mentioned in theREADME.md.To fix these issues, I've done the following:
requirements.txtthat instructspipto installpycryptodomeas well asprogressREADME.mdto use therequirements.txt, and addedprogressas a declared requirementvenv/directoryThis makes the setup process more flexible, and reduces the repository size from 32MB to 5.8MB.
Let me know if anything needs changing!