Remove activities app icons #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This is due to QUERY_ALL_PACKAGES not being allowed to be used in production for our use case
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request removes the usage of the installed_apps package to comply with Play Store restrictions regarding the QUERY_ALL_PACKAGES permission. The changes include the removal of the dependency in pubspec.yaml and disabling the app icon fetching logic in the corresponding utility file.
Files not reviewed (1)
- lib/utils/system_utils.dart: Language not supported
ScreepCode
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Brief Description
This pull request removes, with sadness, the shown icons in the activities list due to the QUERY_ALL_PACKAGES not being allowed to be used in production for our use case.
GitHub Copilot Text
This pull request removes the usage of the
installed_appspackage and its related functionality due to restrictions on theQUERY_ALL_PACKAGESpermission, which is not allowed for release on the Play Store. The most important changes include disabling the app icon fetching logic and removing theinstalled_appsdependency.Removal of
installed_appsfunctionality:lib/utils/system_utils.dart: Disabled thegetInstalledAppIconmethod by commenting out the logic that fetches app icons using theinstalled_appspackage. Added a comment explaining that the method is not usable in production due to Play Store restrictions on theQUERY_ALL_PACKAGESpermission.Dependency cleanup:
pubspec.yaml: Removed theinstalled_appsdependency (^1.5.2) since it is no longer used.