Add the Derivative of the Vandermonde Matrix and Remove the Poetry Lock #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import numpy as np | ||
| import os | ||
| from seissol_matrices import basis_functions, dg_matrices, xml_io | ||
| from seissol_matrices import basis_functions, dg_matrices, json_io |
Contributor
There was a problem hiding this comment.
Does this mean we are fully removing the XML support for the matrices?
Contributor
Author
There was a problem hiding this comment.
Here, it means that we output json instead of XML for those matrices.
...
The reason is: there's no XML support for (not-matrix) tensors yet; and unless there's a reason why it fares better than JSON, I don't think we ever will add it.
vikaskurapati
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add the derivative of the Vandermonde matrix, as used in the plasticity setting, but also in the energy calculation.
Moreover, we remove the Poetry lock file, as it's the source of most of our security issues in the repository. It's probably better to auto-generate it on the fly locally each time.