-
Notifications
You must be signed in to change notification settings - Fork 11
Preparation Quakeworx workshop #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thomas-Ulrich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would use symbolic links as much as possible to the current repo.
does not make sense to duplicate large binary files on a github repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but this file is already in training/kaikoura/ASAGI/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, Thomas! Thanks for the suggestion. One thing that may be easier for the Quakworx specifically is that we would like to ask the audience to download these input files locally on their laptop. Then, we will ask them to upload them to the website. So, it would be easier to explain if all the files are inside the same folder.
Maybe it is an option to keep the duplicated files here until the training is done and then we change this to a link?
|
Just added the jupyter notebook for post processing and the input files for the cdb_tpv23 example. |
|
We are a bit in a time crunch for this one. The SeisSol training will be reviewed tomorrow morning PT by SCEC and SDSC. Let's find a practical way now to merge this and go down the route of symbolic links after the training |
|
Just added another round of edits for tpv13_qwx, which is good to go from my side as of now. |
This reverts commit f4a1de5.
|
Hi @Aangniu , I have just tested all three examples again. Their run times seem fine now using the respective SeisSol app type and were for me:
From my side, this PR could be merged. @Thomas-Ulrich and @AliceGabriel: the main changes are the jupyter notebooks with the SeisSol output visualizations not relying on vtk/pyvista, whose rendering is currently not supported by the Jupyter Notebook Expanse App from the Gateway. |
|
@fabian-kutschera: Thank you, Fabian! They look pretty good now. Thanks for the efforts :) I also think we can merge the current PR now. I added a link to the ReadMe in the quakeworx sub-directory such that audience without access to Git can directly download all the input files from that link. |
|
I would propose to add one commit on top of this PR: |
|
Thank you for creating a new PR with a better practice! I would like to confirm if I understand it correctly :) Would you suggestion to squash PR 55 only? Then the audience will get those input files in the quakeworx directory as well, once they pull the repository? |
|
PR55 contains pr 54 (54 + 1 commit). if I copy then Then it works. |
|
Great! Thanks, Thomas! I just tested. It is working on your branch. I think your method would work for us in this way :) @fabian-kutschera : I also tested on the Gateway Jupyter Notebook server, we can use: and then The quakeworx/ folder with all the files available should be directly download from the Gateway job outputs. This would serve the purpose for us :) |
|
Thanks for your help @Thomas-Ulrich and thanks for testing @Aangniu! |
|
Closing this PR as #55 has been merged successfully. |
@Aangniu here is the preliminary GitHub repo, which we could use for the Quakeworx workshop.
I added the files incl. the meshes you sent me for tpv13 and kaikoura (LSW), but still need to adjust and upload the corresponding notebooks.
Please create a folder for your non-linear example.