-
Notifications
You must be signed in to change notification settings - Fork 18
[Doc] hack sphinx_gallery to have example subsections #1393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @tdavidcl, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the organization of the project's documentation by introducing a custom preprocessing step for the Sphinx Gallery. It addresses the limitation of Sphinx Gallery's inability to handle deeply nested example directories, allowing for a more structured and intuitive presentation of examples. The change involves both a logical restructuring of example files into new subdirectories and a dynamic script that flattens these hierarchies for the documentation build process, ultimately improving navigability and clarity for users exploring the examples. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a preprocessing step in the Sphinx configuration to work around a limitation in sphinx-gallery that prevents nested example directories. The approach involves copying the examples to a temporary directory and flattening the subdirectory structure by renaming nested folders.
My review focuses on improving the maintainability and readability of the new preprocessing script in conf.py. I've suggested encapsulating the logic within a function to keep the global namespace clean and moving imports to the top of the script, which is standard Python practice. I also corrected a minor typo in a comment.
Workflow reportworkflow report corresponding to commit 79bb645 Pre-commit check reportPre-commit check: ✅ Test pipeline can run. Clang-tidy diff reportNo relevant changes found. You should now go back to your normal life and enjoy a hopefully sunny day while waiting for the review. |
Work for the generation, but the toc tree is messed up on the left. We need a way to fix that