Fix Gazebo resource path issue for GRO830`s lab. #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit aims to fix the final issue with GRO830's lab (exercise 12.4) by properly setting the GZ_SIM_RESOURCE_PATH environment variable in the launch file for the Gazebo simulation. The main culprit for this issue seems to be that the resource paths were added to the incorrect environment variable. IGN_GAZEBO_RESOURCE_PATH is for Gazebo Fortress (for ROS2 Humble). From now on, "GZ_SIM" is the correct prefix to use for environment variables. NOTES: - This commit has NOT yet been fully tested on a lab PC, so do NOT merge yet!
MarcOlivierFecteau
force-pushed
the
fix/gro830-lab-gazebo
branch
2 times, most recently
from
3307657 to
813d4f9
Compare
MarcOlivierFecteau
requested review from
IanLalonde,
chameau5050 and
david-brodeur
MarcOlivierFecteau
changed the title
MarcOlivierFecteau
force-pushed
the
fix/gro830-lab-gazebo
branch
from
813d4f9 to
3c85088
Compare
This should ensure the existing values in one's configuration are not overwritten by the launch file. TODO: - Confirm `AppendEnvironmentVariable` creates the environment variable if it does not exist, which is the case for the faculty's lab PCs, BEFORE merging the PR.
MarcOlivierFecteau
force-pushed
the
fix/gro830-lab-gazebo
branch
from
3c85088 to
9a96cfe
Compare
MarcOlivierFecteau
requested review from
MathieuMRodrigue
and removed request for
IanLalonde
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit attempts to fix issues with Gazebo for GRO830's lab by reverting changes made in A24.
NOTES: