Allow custom cache directory via --cache-dir option#282
Merged
adrianna-chang-shopify merged 3 commits intomainfrom Oct 27, 2022
Merged
Allow custom cache directory via --cache-dir option#282adrianna-chang-shopify merged 3 commits intomainfrom
adrianna-chang-shopify merged 3 commits intomainfrom
Conversation
Co-authored-by: Étienne Barrié <etienne.barrie@shopify.com>
Co-authored-by: Étienne Barrié <etienne.barrie@shopify.com>
Schwad
approved these changes
Oct 27, 2022
Schwad
left a comment
Schwad
left a comment
There was a problem hiding this comment.
Neat! I don't have the highest erb-lint context but this PR looks clear to me. 🙌
etiennebarrie
approved these changes
Oct 27, 2022
|
Nice @adrianna-chang-shopify and @etiennebarrie ! Since this is now in, will a release be cut soon? Sorry if I missed that somewhere. |
Author
|
Hey @zachfeldman , I can get a release cut |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Follow up to: #268 (comment)
As discussed in the prior PR, it would be nice to be able to specify the cache directory like you can do with Rubocop.