Check variant files when looking for instance variables#353
Open
iainbeeston wants to merge 1 commit intoShopify:mainfrom
Open
Check variant files when looking for instance variables#353iainbeeston wants to merge 1 commit intoShopify:mainfrom
iainbeeston wants to merge 1 commit intoShopify:mainfrom
Conversation
iainbeeston
force-pushed
the
check-instance-vars-in-variants
branch
from
576d6f1 to
412174e
Compare
iainbeeston
changed the title
iainbeeston
changed the title
iainbeeston
force-pushed
the
check-instance-vars-in-variants
branch
from
412174e to
ff65731
Compare
iainbeeston
force-pushed
the
check-instance-vars-in-variants
branch
from
ff65731 to
84f273b
Compare
There was a bug in the regex used to determine if a template is a partial, which means it was excluding variants.
iainbeeston
force-pushed
the
check-instance-vars-in-variants
branch
from
84f273b to
8eee2cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed there's a bug in the regex used to determine if a template is a partial, which means the partial instance variables linter was missing partials that include a variant in the filename.