[Feature Proposal]add NoLinkToBack linter#370
Open
msasaki666 wants to merge 2 commits intoShopify:mainfrom
Open
[Feature Proposal]add NoLinkToBack linter#370msasaki666 wants to merge 2 commits intoShopify:mainfrom
msasaki666 wants to merge 2 commits intoShopify:mainfrom
Conversation
msasaki666
changed the title
Author
|
I have signed the CLA! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The :back option of the link_to method in Ruby on Rails is handy.
However, there is potential for Reflected XSS attacks through HTTP Referer pollution using dataURL.
↓ Rails doesn't validate dataURL.
https://github.com/rails/rails/blob/main/actionview/lib/action_view/helpers/url_helper.rb#L58
I considered contributing to Rails itself, but due to backwards compatibility issues, I didn't think I could change that right away.
So I thought about adding a custom linter to this wonderful gem.
I figured other developers might have similar problems, so I have now issued a PR.
If you don't need it, feel free to close it.