Add ignored_words option to HardCodedString linter#397
Open
krzyzak wants to merge 1 commit intoShopify:mainfrom
Open
Add ignored_words option to HardCodedString linter#397krzyzak wants to merge 1 commit intoShopify:mainfrom
ignored_words option to HardCodedString linter#397krzyzak wants to merge 1 commit intoShopify:mainfrom
Conversation
Author
|
I have signed the CLA! |
krzyzak
force-pushed
the
add-ignored-words-to-hardcoded-string-linter
branch
from
ee29308 to
32985b4
Compare
Contributor
|
This would be great to see merged. I'm a maintainer over at OpenStreetMap and I would like to use this to add |
gravitystorm
added a commit
to gravitystorm/openstreetmap-website
that referenced
this pull request
Jan 7, 2026
The implementation uses a customised linter, to add `·` to the list of punctuation that doesn't need translating. We can remove our customised linter when this list becomes a config option, see Shopify/erb_lint#397
snehaljadhav7317
pushed a commit
to snehaljadhav7317/openstreetmap-website
that referenced
this pull request
Jan 17, 2026
The implementation uses a customised linter, to add `·` to the list of punctuation that doesn't need translating. We can remove our customised linter when this list becomes a config option, see Shopify/erb_lint#397
snehaljadhav7317
pushed a commit
to snehaljadhav7317/openstreetmap-website
that referenced
this pull request
Jan 17, 2026
The implementation uses a customised linter, to add `·` to the list of punctuation that doesn't need translating. We can remove our customised linter when this list becomes a config option, see Shopify/erb_lint#397
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for custom translation exceptions via configuration. Users can now specify additional strings that should be exempt from translation requirements, alongside the default
NO_TRANSLATION_NEEDEDlist. This is useful for:Usage example: