Prevent opening ERB line from being a rubocop violation#413
Open
brymacto wants to merge 1 commit intoShopify:mainfrom
Open
Prevent opening ERB line from being a rubocop violation#413brymacto wants to merge 1 commit intoShopify:mainfrom
brymacto wants to merge 1 commit intoShopify:mainfrom
Conversation
Author
|
I have signed the CLA! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #331.
This fixes a problem where erb like:
Would result in the first line being considered a
Layout/TrailingWhitespaceoffense. When used with--autocorrect, this would break the erb file by updating it to:This fix will consider whether the source line is an erb tag only, and if so, not consider that a violation.
I'm not completely sure if this is the right fix or if there is a better fix that could be made at a different point, such as when parsing before trying to identify offenses. Very open to feedback if there are better approaches.