Skip to content

Fix: Ensure VariantPicker initialization handles all fieldsets correctly #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iminiscript wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −3
Open

Fix: Ensure VariantPicker initialization handles all fieldsets correctly #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions assets/variant-picker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,11 @@ export default class VariantPicker extends Component {
this.#radios.push(radios);

const initialCheckedIndex = radios.findIndex((radio) => radio.dataset.currentChecked === 'true');
if (initialCheckedIndex !== -1) {
this.#checkedIndices.push([initialCheckedIndex]);
}

// TARGETED FIX: Always push an array to match the index of fieldsets.
// This ensures 'checkedIndices' is not undefined in updateSelectedOption
// when a user selects an option in a previously unchecked fieldset.
this.#checkedIndices.push(initialCheckedIndex !== -1 ? [initialCheckedIndex] : []);
});

this.addEventListener('change', this.variantChanged.bind(this));
Expand Down