Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Oct 1, 2025

  • Analyze the issue: EnableChromiumLogging property is checked in constructor's ResetChromiumArguments() before console app sets the property
  • Modify EnableChromiumLogging property to dynamically add/remove Chromium logging arguments when set
  • Test the fix by building the solution
  • Verify the fix handles edge cases (setting before/after Chrome starts)
Original prompt

This section details on the original issue you should resolve

<issue_title>EnableChromiumLogging does not work in the console application</issue_title>
<issue_description>If I understand the code correctly the Converter checks for its EnableChromiumLogging property in a call to ResetChromiumArguments in its constructor. At that time the console program has, however, not yet set this property because it does so with its SetConverterSettings after creating the instance.

(Because of sandboxing and IIS app pool issues (again) I had to debug the starting of Chrome and noticed that no log file was ever created. I then recompiled CHTP and hardcoded Chrome logging which then worked)</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes #197

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@Sicos1977 Sicos1977 marked this pull request as ready for review October 1, 2025 08:41
@Sicos1977 Sicos1977 merged commit 0752a03 into master Oct 1, 2025
1 check failed
Copilot AI requested a review from Sicos1977 October 1, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EnableChromiumLogging does not work in the console application

2 participants