Update TypeScript typings with generic type parameters (#1061)#10
Open
MitchLewis930 wants to merge 2 commits intopr_030_beforefrom
Open
Update TypeScript typings with generic type parameters (#1061)#10MitchLewis930 wants to merge 2 commits intopr_030_beforefrom
MitchLewis930 wants to merge 2 commits intopr_030_beforefrom
Conversation
…ethods & AxiosResponse
Update TypeScript typings with generic type parameters
MitchLewis930
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| request(config: AxiosRequestConfig): AxiosPromise; | ||
| get(url: string, config?: AxiosRequestConfig): AxiosPromise; | ||
| request<T = any>(config: AxiosRequestConfig): AxiosPromise<T>; | ||
| get<T = any>(url: string, config?: AxiosRequestConfig): AxiosPromise<T>; |
There was a problem hiding this comment.
Missing generic type parameter on delete and head methods
Medium Severity
The delete and head methods in AxiosInstance were not updated with generic type parameters <T = any>, unlike request, get, post, put, and patch. This creates an inconsistent API where typed responses work for most HTTP methods but not for delete and head. Users cannot write axios.delete<User>('/user') to get a typed response.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR_030
Note
Low Risk
Type-definition-only change that improves compile-time typing; risk is limited to potential TypeScript compatibility/regression for consumers relying on the old untyped signatures.
Overview
Adds generic type parameters to the TypeScript definitions for
AxiosResponseandAxiosPromise, and threads those generics throughAxiosAdapterplusAxiosInstancemethods (request,get,post,put,patch) so callers can type responsedata.Updates the TypeScript type tests to exercise the new generic call signatures (e.g.,
axios.get<User>()) and validate strongly-typed access toresponse.datafields.Written by Cursor Bugbot for commit 7133141. This will update automatically on new commits. Configure here.