fix(fetch): use current global fetch instead of cached one when env f…#2
Open
MitchLewis930 wants to merge 1 commit intopr_022_beforefrom
Open
fix(fetch): use current global fetch instead of cached one when env f…#2MitchLewis930 wants to merge 1 commit intopr_022_beforefrom
MitchLewis930 wants to merge 1 commit intopr_022_beforefrom
Conversation
…etch is not specified to keep MSW support; (axios#7030)
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| skipUndefined: true | ||
| }, globalFetchAPI, config ? config.env : null); | ||
|
|
||
| let env = config ? config.env : {}; |
There was a problem hiding this comment.
TypeError when config.env is undefined in getFetch
High Severity
The expression config ? config.env : {} evaluates to undefined when config exists but lacks an env property. Since getFetch(config) is called from adapters.js with the full request config (which normally doesn't include env), destructuring undefined on the next line throws a TypeError. The original code used utils.merge which safely handles undefined arguments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


PR_022
Note
Low Risk
Small behavior change scoped to the fetch adapter’s selection of
fetchwhen env overrides are absent; low risk but could affect environments relying on prior caching semantics.Overview
Ensures the fetch adapter uses the current global
fetchimplementation whenconfig.env.fetchis not provided/undefined, instead of relying on a previously cached reference.This updates
factory()to merge env defaults without capturingfetch, selects_fetch = envFetch || fetchat request time, and adjustsgetFetch()seeding so env merging doesn’t cache a globalfetch. Adds a unit test that monkey-patches globalfetchand verifies the adapter picks up the new implementation.Written by Cursor Bugbot for commit cf78825. This will update automatically on new commits. Configure here.