Refactor mergeConfig without utils.deepMerge (#2844)#3
Refactor mergeConfig without utils.deepMerge (#2844)#3MitchLewis930 wants to merge 1 commit intopr_023_beforefrom
Conversation
* Adding failing test * Fixing axios#2587 default custom config persisting * Adding Concat keys and filter duplicates * Fixed value from CPE * update for review feedbacks * no deepMerge * only merge between plain objects * fix rename * always merge config by mergeConfig * extract function mergeDeepProperties * refactor mergeConfig with all keys, and add special logic for validateStatus * add test for resetting headers * add lots of tests and fix a bug * should not inherit `data` * use simple toString * revert axios#1845 Co-authored-by: David Tanner <david.tanner@lifeomic.com> Co-authored-by: Justin Beckwith <justin.beckwith@gmail.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| } | ||
| ); | ||
|
|
||
| // Remove header where value is null |
There was a problem hiding this comment.
Null-valued headers no longer removed before sending requests
High Severity
The code that filtered out headers with null values was removed from dispatchRequest.js. Previously, setting a header to null would remove it from the request (useful for overriding default headers). Now, null-valued headers are passed to XMLHttpRequest.setRequestHeader(), which stringifies null to the string "null" and sends it in the request. This breaks the documented pattern of using null to unset default headers and will cause unexpected header values in production requests.
| config[prop] = config1[prop]; | ||
| } | ||
| }); | ||
| utils.forEach(otherKeys, mergeDeepProperties); |
There was a problem hiding this comment.
Duplicate keys cause redundant processing in otherKeys loop
Low Severity
otherKeys is built by concatenating Object.keys(config1) and Object.keys(config2) without deduplication. When both configs have the same custom property, mergeDeepProperties will be called twice for that key. Consider deduplicating with Array.from(new Set(...)) or filtering duplicates.
2 participants
PR_023
Note
Medium Risk
Touches core request config/headers merging behavior, which can subtly change how user overrides (especially
headersandvalidateStatus) are applied across all requests.Overview
Refactors
mergeConfigand related merging utilities.Axiosmethod aliases now usemergeConfigdirectly, andmergeConfigis rewritten to rely on a newutils.isPlainObjectplus an enhancedutils.merge(array cloning + plain-object-only deep merge), removingutils.deepMergeentirely.This changes config merging semantics: adds/handles more known config keys, treats
validateStatusas a direct-merge key (allowing explicitundefined/nulloverrides), preservesnull/undefinedheader values rather than deleting them duringdispatchRequest, and broadens merging to include custom/default config keys with cloning to avoid shared references. Tests are expanded/updated accordingly (including removingdeepMergespecs and adding coverage for header reset andvalidateStatusbehavior).Written by Cursor Bugbot for commit 0d69a79. This will update automatically on new commits. Configure here.