fix(http): treat http://localhost as base URL for relative paths to a…#4
Open
MitchLewis930 wants to merge 1 commit intopr_024_beforefrom
Open
fix(http): treat http://localhost as base URL for relative paths to a…#4MitchLewis930 wants to merge 1 commit intopr_024_beforefrom
MitchLewis930 wants to merge 1 commit intopr_024_beforefrom
Conversation
…void `ERR_INVALID_URL` error; (axios#5528)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR_024
Note
Low Risk
Single-line change limited to URL parsing; behavior change only affects cases where
fullPathis relative, with minimal impact on normal absolute-URL requests.Overview
Fixes URL parsing for relative request paths in the Node
httpadapter.new URL(fullPath)now useshttp://localhostas a fallback base (new URL(fullPath, 'http://localhost')), preventing errors whenconfig.url(afterbuildFullPath) is a relative URL and ensuring protocol/host extraction works consistently.Written by Cursor Bugbot for commit 128d56f. This will update automatically on new commits. Configure here.