fix: capture async stack only for rejections with native error object…#5
Open
MitchLewis930 wants to merge 1 commit intopr_025_beforefrom
Open
fix: capture async stack only for rejections with native error object…#5MitchLewis930 wants to merge 1 commit intopr_025_beforefrom
MitchLewis930 wants to merge 1 commit intopr_025_beforefrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR_025
Note
Low Risk
Tightly scoped change to error stack formatting and a related unit test; main risk is subtle differences in stack strings across runtimes.
Overview
Improves error stack preservation in
Axios.request()by only capturing and appending the async call-site stack when the rejection is a nativeError, and by handling cases whereerr.stackis missing before merging.Updates the HTTP adapter unit test for stack preservation to use async/await server startup (
startHTTPServer) and return theassert.rejectspromise, keeping the single-occurrence stack assertion intact.Written by Cursor Bugbot for commit 1a08f90. This will update automatically on new commits. Configure here.