Skip to content

Fixing an issue that type 'null' is not assignable to validateStatus … #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MitchLewis930 wants to merge 1 commit into
base: pr_028_before
Choose a base branch
from
Open

Fixing an issue that type 'null' is not assignable to validateStatus … #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@ export interface AxiosRequestConfig {
onUploadProgress?: (progressEvent: ProgressEvent) => void;
onDownloadProgress?: (progressEvent: ProgressEvent) => void;
maxContentLength?: number;
validateStatus?: ((status: number) => boolean | null);
Copy link

@cursor cursor bot Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong parentheses placement in validateStatus type definition

High Severity

The validateStatus type has incorrect parentheses placement. The current type ((status: number) => boolean | null) defines a function returning boolean | null. However, the PR intends to fix setting validateStatus itself to null (to accept all HTTP status codes). The correct type is ((status: number) => boolean) | null, where the property can be either a function OR null. This doesn't fix the reported issue and incorrectly changes the function's return type semantics.

Fix in Cursor Fix in Web

maxBodyLength?: number;
validateStatus?: (status: number) => boolean;
maxRedirects?: number;
socketPath?: string | null;
httpAgent?: any;
Expand Down