Fixing defaults to use httpAdapter if available (#1285)#9
Open
MitchLewis930 wants to merge 1 commit intopr_029_beforefrom
Open
Fixing defaults to use httpAdapter if available (#1285)#9MitchLewis930 wants to merge 1 commit intopr_029_beforefrom
MitchLewis930 wants to merge 1 commit intopr_029_beforefrom
Conversation
* Fixing defaults to use httpAdapter if available * Use a safer, cross-platform method to detect the Node environment
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| adapter = require('./adapters/xhr'); | ||
| } else if (typeof process !== 'undefined') { | ||
| // Only Node.JS has a process variable that is of [[Class]] process | ||
| if (typeof process !== 'undefined' && Object.prototype.toString.call(process) === '[object process]') { |
There was a problem hiding this comment.
Detection check may fail on older Node.js versions
Medium Severity
The check Object.prototype.toString.call(process) === '[object process]' may not work on older Node.js versions (6.x, 8.x) where Symbol.toStringTag wasn't set on the process object. In those versions, Object.prototype.toString.call(process) returns '[object Object]', causing the condition to fail. Since XMLHttpRequest also doesn't exist in pure Node.js, the adapter variable remains undefined, which would break axios requests entirely on older Node.js runtimes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR_029
Note
Low Risk
Small, localized change to environment detection for adapter selection; risk is limited to edge runtimes where
process/XMLHttpRequestare polyfilled differently.Overview
Fixes default adapter detection so the
httpadapter is selected only whenprocessexists and is actually a Node.js process ([object process]), and otherwise falls back to the XHR adapter whenXMLHttpRequestis available.This reorders the checks from “XHR first” to “Node-first with stricter guard”, reducing cases where bundlers/polyfills or non-Node runtimes incorrectly trigger the Node adapter.
Written by Cursor Bugbot for commit 0b3db5d. This will update automatically on new commits. Configure here.