Fixing an issue that type 'null' is not assignable to validateStatus …

[MitchLewis930]

PR_028

Summary by CodeRabbit

Release Notes

• Refactor
  • Updated request validation configuration type system to support extended return values, enabling more flexible validation logic in API request handling.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

The validateStatus method signature in the AxiosRequestConfig TypeScript type definition has been updated to accept null as a valid return value alongside boolean, expanding the validation contract without removing the property.

Changes

Cohort / File(s)	Summary
Type Definition Update index.d.ts	Updated validateStatus method return type from (status: number) => boolean to (status: number) => boolean | null, allowing null as a valid return value in the validation function.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A status check, now with a twist so fine,
Boolean or null—the types align,
One tiny change, so small and neat,
Makes validation feel complete!

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: updating the validateStatus type signature to allow null returns, which directly addresses the issue of null not being assignable.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[MitchLewis930]

@CodeRabbit full review

[coderabbitai]

✅ Actions performed

Full review triggered.

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@index.d.ts`:
- Line 65: The type for validateStatus is wrong: it currently defines a function
that returns boolean|null but should allow the entire property to be null;
change the signature for validateStatus so the union applies to the property
(i.e., ((status: number) => boolean) | null) instead of ((status: number) =>
boolean | null), updating the declaration named validateStatus in index.d.ts so
callers can assign null to the property itself.

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 029c36e and b03f161.

📒 Files selected for processing (1)

• index.d.ts

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

[coderabbitai]

⚠️ Potential issue | 🟠 Major

LGTM! Type signature correctly allows null return value.

The change properly expands the return type to boolean | null, which fixes the type error when users return null from their validateStatus implementation. The parentheses correctly scope the union type to the return value.Important: The type signature should be ((status: number) => boolean) | null rather than ((status: number) => boolean | null). The current implementation parses as a function that returns boolean | null, but the intended fix should allow the entire property to be set to null.

According to Axios documentation, validateStatus can be assigned a function, undefined, or null to the property itself. When set to null or undefined, all status codes resolve the promise.

🐛 Proposed fix for the type signature

-  validateStatus?: ((status: number) => boolean | null);
+  validateStatus?: ((status: number) => boolean) | null;

This was also noted in the original Axios PR discussion where the same mistake was made and later corrected in PR #3200.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	validateStatus?: ((status: number) => boolean | null);
	validateStatus?: ((status: number) => boolean) | null;

🤖 Prompt for AI Agents

In `@index.d.ts` at line 65, The type for validateStatus is wrong: it currently
defines a function that returns boolean|null but should allow the entire
property to be null; change the signature for validateStatus so the union
applies to the property (i.e., ((status: number) => boolean) | null) instead of
((status: number) => boolean | null), updating the declaration named
validateStatus in index.d.ts so callers can assign null to the property itself.