fix(http): treat http://localhost as base URL for relative paths to a…#4
Open
MitchLewis930 wants to merge 1 commit intopr_024_beforefrom
Open
fix(http): treat http://localhost as base URL for relative paths to a…#4MitchLewis930 wants to merge 1 commit intopr_024_beforefrom
MitchLewis930 wants to merge 1 commit intopr_024_beforefrom
Conversation
…void `ERR_INVALID_URL` error; (axios#5528)
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue in the HTTP adapter where relative URLs were not being properly handled. The change treats http://localhost as a base URL when parsing URLs, allowing relative paths to be resolved correctly.
Changes:
- Modified URL parsing in the HTTP adapter to support relative URLs by providing a default base URL
| // Parse url | ||
| const fullPath = buildFullPath(config.baseURL, config.url); | ||
| const parsed = new URL(fullPath); | ||
| const parsed = new URL(fullPath, 'http://localhost'); |
There was a problem hiding this comment.
Using 'http://localhost' as a base URL could cause issues when fullPath is already an absolute URL with a different protocol (e.g., 'https://example.com'). The URL constructor will incorrectly parse absolute URLs when given a base. Consider checking if fullPath is absolute before providing a base URL, or handle the case where the parsed URL doesn't match the intended target.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR_024