fix: capture async stack only for rejections with native error object…#5
Open
MitchLewis930 wants to merge 1 commit intopr_025_beforefrom
Open
fix: capture async stack only for rejections with native error object…#5MitchLewis930 wants to merge 1 commit intopr_025_beforefrom
MitchLewis930 wants to merge 1 commit intopr_025_beforefrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where async stack traces were being incorrectly captured for non-Error rejections. The fix ensures stack trace augmentation only occurs when the rejected value is an instance of the native Error object.
Changes:
- Modified the stack trace capture logic to only apply to Error instances
- Refactored test case to use async/await pattern instead of callbacks
- Added safety checks for stack property existence
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/core/Axios.js | Added instanceof Error check to conditionally capture and augment stack traces only for Error objects |
| test/unit/adapters/http.js | Converted callback-based test to async/await pattern using startHTTPServer helper |
Comment on lines
+43
to
+45
| let dummy; | ||
|
|
||
| Error.captureStackTrace ? Error.captureStackTrace(dummy = {}) : (dummy = new Error()); |
There was a problem hiding this comment.
The ternary operator assigns different types to dummy (object vs Error instance). This inconsistency could cause issues when accessing properties. Consider using dummy = {}; Error.captureStackTrace ? Error.captureStackTrace(dummy) : (dummy.stack = new Error().stack); to keep dummy consistently as a plain object.
Suggested change
| let dummy; | |
| Error.captureStackTrace ? Error.captureStackTrace(dummy = {}) : (dummy = new Error()); | |
| let dummy = {}; | |
| if (Error.captureStackTrace) { | |
| Error.captureStackTrace(dummy); | |
| } else { | |
| dummy.stack = (new Error()).stack; | |
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR_025