Fixing defaults to use httpAdapter if available (#1285)#9
Open
MitchLewis930 wants to merge 1 commit intopr_029_beforefrom
Open
Fixing defaults to use httpAdapter if available (#1285)#9MitchLewis930 wants to merge 1 commit intopr_029_beforefrom
MitchLewis930 wants to merge 1 commit intopr_029_beforefrom
Conversation
* Fixing defaults to use httpAdapter if available * Use a safer, cross-platform method to detect the Node environment
There was a problem hiding this comment.
Pull request overview
This PR reorders the adapter detection logic in getDefaultAdapter() to prioritize the HTTP adapter for Node.js environments over the XHR adapter for browsers, while adding a more robust check to identify genuine Node.js processes.
Changes:
- Swapped the order of adapter detection, checking for Node.js environment first before browser environment
- Added a more specific Node.js detection using
Object.prototype.toString.call(process) === '[object process]'to avoid false positives
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR_029