fix: Adding ipv6 check on the node init function#10
Open
MitchLewis930 wants to merge 1 commit intopr_050_beforefrom
Open
fix: Adding ipv6 check on the node init function#10MitchLewis930 wants to merge 1 commit intopr_050_beforefrom
MitchLewis930 wants to merge 1 commit intopr_050_beforefrom
Conversation
Cilium pods on a single stack cluster were failing when ipv6 was enabled. The change would make sure that if the underlying node does not have ipv6 configuration enabled it would fail even if KPR is disabled.Earlier, if KPR is enabled, the node would not see a fatal error. Signed-off-by: Vipul Singh <singhvipul@microsoft.com>
Greptile OverviewGreptile SummaryAdded early validation in Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant API as Kubernetes API
participant WNI as WaitForNodeInformation
participant RNI as retrieveNodeInformation
participant Node as Node Object
participant Config as option.Config
participant Logger as Log
WNI->>Config: Check nodeName
alt nodeName is empty
WNI-->>WNI: Return nil (skip validation)
else nodeName exists
WNI->>RNI: retrieveNodeInformation(ctx, log, localNode, localCiliumNode)
RNI->>API: Watch for Node/CiliumNode events
API-->>RNI: Return node resource
RNI-->>WNI: Return Node object
alt Node object received
WNI->>Node: GetNodeIP(false) - IPv4
Node-->>WNI: nodeIP4
WNI->>Node: GetNodeIP(true) - IPv6
Node-->>WNI: nodeIP6
WNI->>Logger: Log node information
Note over WNI,Config: New IPv6 validation check
WNI->>Config: Check EnableIPv6
alt EnableIPv6 && nodeIP6 == nil
WNI->>Logger: Error: No IPv6 support
WNI-->>WNI: Return error (node has no IPv6)
else IPv6 check passes
WNI->>WNI: useNodeCIDR(n)
WNI-->>WNI: Success
end
else Node object not received
alt CIDR required
WNI-->>WNI: Return error (unable to derive PodCIDR)
else CIDR not required
WNI-->>WNI: Success
end
end
end
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR_050