cec: support for explicit control of Cilium Envoy filter injection

[MitchLewis930]

PR_045

[greptile-apps]

Greptile Overview

Greptile Summary

This PR introduces explicit control over Cilium Envoy filter injection through a new annotation cec.cilium.io/inject-cilium-filters. Previously, Cilium filters were automatically injected only when L7 load balancing services were defined. This change allows users to explicitly enable or disable filter injection via annotation, overriding the default behavior.

Key Changes:

• Added new CECPrefix and CECInjectCiliumFilters annotation constants
• Created injectCiliumEnvoyFilters() helper function to determine filter injection based on annotation or service presence
• Separated isL7LB parameter from filter injection logic in parseResources()
• Added comprehensive test coverage for the new annotation-based control

Critical Issue Found:

• addCiliumEnvoyConfig() at line 92-93 incorrectly passes len(cecSpec.Services) > 0 twice instead of calling injectCiliumEnvoyFilters(), breaking the annotation-based control for newly added configs

Confidence Score: 1/5

• This PR has a critical bug that breaks the main feature for new CEC additions
• The implementation contains a critical logic error in addCiliumEnvoyConfig that prevents the annotation-based filter control from working when adding new CiliumEnvoyConfig resources. While update and delete paths are correct, and test coverage is comprehensive, the bug in the add path means the feature's primary use case is broken.
• Pay close attention to pkg/ciliumenvoyconfig/cec_manager.go - the bug at lines 92-93 must be fixed

Important Files Changed

Filename	Overview
pkg/ciliumenvoyconfig/cec_manager.go	Critical bug in addCiliumEnvoyConfig - incorrect parameter passed, preventing annotation-based filter control
pkg/annotation/k8s.go	Added new CEC annotation constant and prefix, simple and safe change
pkg/ciliumenvoyconfig/cec_resource_parser.go	Separated isL7LB and injectCiliumEnvoyFilters parameters for explicit filter injection control

Sequence Diagram

sequenceDiagram
    participant User as User/K8s API
    participant CEC as CEC Manager
    participant Helper as injectCiliumEnvoyFilters
    participant Parser as CEC Resource Parser
    participant Envoy as Envoy Config

    User->>CEC: Create/Update CiliumEnvoyConfig
    Note over User,CEC: With annotation cec.cilium.io/inject-cilium-filters
    
    CEC->>Helper: injectCiliumEnvoyFilters(metadata, spec)
    
    alt Annotation exists
        Helper->>Helper: Parse annotation value
        alt Valid boolean
            Helper-->>CEC: Return parsed boolean
        else Invalid value
            Helper-->>CEC: Fall back to len(spec.Services) > 0
        end
    else No annotation
        Helper-->>CEC: Return len(spec.Services) > 0
    end
    
    CEC->>Parser: parseResources(..., injectCiliumEnvoyFilters, ...)
    
    alt injectCiliumEnvoyFilters == true
        Parser->>Parser: Inject Cilium Network filters
        Parser->>Parser: Inject Cilium L7 filters
        Parser-->>CEC: Resources with Cilium filters
    else injectCiliumEnvoyFilters == false
        Parser-->>CEC: Resources without Cilium filters
    end
    
    CEC->>Envoy: Apply Envoy configuration

Loading

[greptile-apps]

_{3 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

incorrect parameter passed to parseResources - should call injectCiliumEnvoyFilters(&cecObjectMeta, cecSpec) instead of len(cecSpec.Services) > 0

Suggested change

	len(cecSpec.Services) > 0,
	len(cecSpec.Services) > 0,
	len(cecSpec.Services) > 0,
	injectCiliumEnvoyFilters(&cecObjectMeta, cecSpec),

Prompt To Fix With AI

This is a comment left during a code review.
Path: pkg/ciliumenvoyconfig/cec_manager.go
Line: 92:93

Comment:
incorrect parameter passed to `parseResources` - should call `injectCiliumEnvoyFilters(&cecObjectMeta, cecSpec)` instead of `len(cecSpec.Services) > 0`

```suggestion
		len(cecSpec.Services) > 0,
		injectCiliumEnvoyFilters(&cecObjectMeta, cecSpec),
```

How can I resolve this? If you propose a fix, please make it concise.