aws/ec2: properly paginate DescribeNetworkInterfaces results

[MitchLewis930]

PR_046

[greptile-apps]

Greptile Overview

Greptile Summary

Added explicit MaxResults parameter (set to 1000) to three DescribeNetworkInterfaces API calls to improve pagination efficiency and consistency.

• Modified describeNetworkInterfaces(), describeNetworkInterfacesByInstance(), and describeNetworkInterfacesFromInstances() in pkg/aws/ec2/ec2.go
• Introduced ENIMaxResultsPerApiCall constant (value: 1000) in pkg/defaults/defaults.go
• All three functions already use paginators correctly, ensuring all results are fetched across multiple pages
• 1000 is the maximum value allowed by AWS EC2 API for DescribeNetworkInterfaces

This change optimizes API calls by requesting the maximum number of results per page instead of relying on AWS default page sizes, reducing the total number of API calls needed for large result sets.

Confidence Score: 5/5

• This PR is safe to merge with no concerns
• The changes are minimal, well-scoped, and correct. The constant value of 1000 matches the AWS API maximum, and all modified functions already use proper pagination patterns. This is a pure optimization that reduces API calls without changing behavior.
• No files require special attention

Important Files Changed

Filename	Overview
pkg/aws/ec2/ec2.go	Added MaxResults parameter to three DescribeNetworkInterfaces calls for proper pagination control
pkg/defaults/defaults.go	Introduced ENIMaxResultsPerApiCall constant set to 1000 (AWS API maximum)

Sequence Diagram

sequenceDiagram
    participant Client as EC2 Client
    participant AWS as AWS EC2 API
    participant Paginator as DescribeNetworkInterfacesPaginator
    
    Note over Client: describeNetworkInterfaces() called
    Client->>Client: Create DescribeNetworkInterfacesInput<br/>with MaxResults=1000
    Client->>Paginator: NewDescribeNetworkInterfacesPaginator(input)
    
    loop while paginator.HasMorePages()
        Client->>Client: limiter.Limit() - rate limiting
        Client->>Paginator: NextPage(ctx)
        Paginator->>AWS: DescribeNetworkInterfaces<br/>(MaxResults: 1000)
        AWS-->>Paginator: NetworkInterfaces (up to 1000)<br/>+ NextToken if more exist
        Paginator-->>Client: Output with NetworkInterfaces
        Client->>Client: Append results to result array
    end
    
    Client-->>Client: Return all NetworkInterfaces

Loading

[greptile-apps]

_{2 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}