operator: fix errors/warnings metric.

[MitchLewis930]

PR_048

[greptile-apps]

Greptile Overview

Greptile Summary

This PR fixes the errors_warnings metric in the Cilium operator by adding proper initialization that was previously missing. The operator doesn't use the pkg/metrics/Cell module (which the agent uses), so it needs to manually initialize the ErrorsWarnings metric before it can be used by the LoggingHook.

Key changes:

• Added InitOperatorMetrics() to initialize the ErrorsWarnings metric for the operator
• Extracted newErrorsWarningsMetric() helper to deduplicate metric creation logic
• Added FlushLoggingMetrics() function using sync.Once for thread-safe, idempotent flushing
• Operator now calls InitOperatorMetrics(), registers the metric, then calls FlushLoggingMetrics() in correct order
• Refactored agent path to use the new FlushLoggingMetrics() function for consistency

The implementation is solid with proper ordering (initialize → register → flush) and thread-safety via sync.Once.

Confidence Score: 5/5

• This PR is safe to merge with no issues found
• The changes follow established patterns, have proper thread-safety with sync.Once, maintain correct ordering of operations, and improve code organization by extracting reusable functions. The fix addresses a real issue where operator metrics weren't being initialized properly.
• No files require special attention

Important Files Changed

Filename	Overview
operator/metrics/metrics.go	Added operator-specific initialization for ErrorsWarnings metric with proper ordering: init, register, then flush
pkg/metrics/cell.go	Refactored to use new FlushLoggingMetrics() function for cleaner code
pkg/metrics/logging_hook.go	Added FlushLoggingMetrics() function with sync.Once for thread-safe, idempotent metric flushing
pkg/metrics/metrics.go	Added InitOperatorMetrics() and extracted newErrorsWarningsMetric() helper to support operator-specific initialization

Sequence Diagram

sequenceDiagram
    participant Init as Operator Init
    participant Hook as LoggingHook
    participant RegMgr as registerMetricsManager
    participant Metrics as pkg/metrics
    participant Prom as Prometheus Registry

    Note over Init,Hook: Early initialization
    Init->>Hook: NewLoggingHook()
    Hook->>Metrics: Create metricsInitialized channel
    Note over Hook: Starts goroutine waiting<br/>on metricsInitialized

    Note over Hook: Errors/warnings logged<br/>accumulate in atomic counters

    Note over RegMgr,Prom: Hive cell initialization
    RegMgr->>Metrics: InitOperatorMetrics()
    Metrics->>Metrics: ErrorsWarnings = newErrorsWarningsMetric()
    
    RegMgr->>Prom: Registry.MustRegister(ErrorsWarnings)
    
    RegMgr->>Metrics: FlushLoggingMetrics()
    Metrics->>Metrics: flushMetrics.Do(close channel)
    Note over Hook: Goroutine unblocks
    Hook->>Metrics: ErrorsWarnings.WithLabelValues().Add()
    Note over Hook: Accumulated errors/warnings<br/>flushed to metric

Loading

[greptile-apps]

_{4 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}