aws/ec2: properly paginate DescribeNetworkInterfaces results

[MitchLewis930]

User description

PR_046

---

PR Type

Enhancement, Bug fix

---

Description

• Add pagination support to DescribeNetworkInterfaces API calls

• Set MaxResults parameter to 1000 for all three ENI query methods

• Define ENIMaxResultsPerApiCall constant in defaults package

• Ensures proper handling of large result sets across all EC2 queries

---

Diagram Walkthrough

flowchart LR
  A["EC2 Client Methods"] -->|Add MaxResults| B["DescribeNetworkInterfaces Input"]
  C["defaults Package"] -->|Define Constant| D["ENIMaxResultsPerApiCall = 1000"]
  D -->|Used by| B
  B -->|Enables| E["Proper API Pagination"]

Loading

File Walkthrough

	Relevant files
Enhancement	ec2.go Add MaxResults pagination to three ENI query methods          pkg/aws/ec2/ec2.go Import defaults package for accessing ENIMaxResultsPerApiCall constant Add MaxResults parameter to describeNetworkInterfaces method Add MaxResults parameter to describeNetworkInterfacesByInstance method Add MaxResults parameter to describeNetworkInterfacesFromInstances method +4/-0
Configuration changes	defaults.go Define ENI API pagination limit constant                                  pkg/defaults/defaults.go Define new constant ENIMaxResultsPerApiCall with value 1000 Document the constant as maximum ENI objects per DescribeNetworkInterfaces call +3/-0

---

[qodo-code-review]

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢	No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
⚪	🎫 No ticket provided Create ticket/issue
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
🟢	Generic: Comprehensive Audit Trails Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Meaningful Naming and Self-Documenting Code Objective: Ensure all identifiers clearly express their purpose and intent, making code self-documenting Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Robust Error Handling and Edge Case Management Objective: Ensure comprehensive error handling that provides meaningful context and graceful degradation Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Error Handling Objective: To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Logging Practices Objective: To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Security-First Input Validation and Data Handling Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities Status: Passed Learn more about managing compliance generic rules or creating your own custom rules

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

[qodo-code-review]

PR Code Suggestions ✨

No code suggestions found for the PR.