Fix: css in next/dynamic component in edge runtime (#64382)#1
Open
MitchLewis930 wants to merge 1 commit intopr_031_beforefrom
Open
Fix: css in next/dynamic component in edge runtime (#64382)#1MitchLewis930 wants to merge 1 commit intopr_031_beforefrom
MitchLewis930 wants to merge 1 commit intopr_031_beforefrom
Conversation
### What Wrap async local storage for all edge runtime routes in adapter Basically fixed the case reported in [this tweet](https://x.com/keegandonley/status/1778538456458854880) ### Why We're relying on the ALS for dynamic css preloading but we didn't wrap the ALS for request handlers for edge. So if you have CSS imports in `next/dynamic` in edge runtime it would break. Closes NEXT-3085
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR_031
Note
Medium Risk
Touches the core Edge request adapter by changing async storage scoping for all requests, which could affect per-request context propagation. Changes are small and covered by a targeted E2E regression test.
Overview
Fixes
next/dynamicCSS preloading in the Edge runtime by ensuring the adapter wraps all requests (not just middleware) inRequestAsyncStorageWrapper, making a request store available during rendering.Updates
PreloadCssto callgetExpectedRequestStore('next/dynamic css')(and type the require) for clearer error attribution when invoked outside a request scope, and adds an E2E test route (/ssr/edge) plus coverage to verify only the correct dynamic CSS is applied under Edge runtime.Written by Cursor Bugbot for commit 56d0988. This will update automatically on new commits. Configure here.