fix(next/image): fix image-optimizer.ts headers (#82114)#2
Open
MitchLewis930 wants to merge 1 commit intopr_032_beforefrom
Open
fix(next/image): fix image-optimizer.ts headers (#82114)#2MitchLewis930 wants to merge 1 commit intopr_032_beforefrom
MitchLewis930 wants to merge 1 commit intopr_032_beforefrom
Conversation
The headers were forwarded to the serverless function for "internal" images but not "external" images. This changes the behavior to be the same for both such that neither receive headers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR_032
Note
Medium Risk
Changes request header propagation in the image optimizer, which can affect apps relying on cookies/headers for authenticated internal image endpoints and may alter caching/response behavior.
Overview
Stops
fetchInternalImagefrom passing the original request’s headers intocreateRequestResponseMocks, so internal/_next/imageoptimization requests no longer inherit client headers likeCookie.Adds an integration API route (
/api/conditional-cookie) and a new test asserting that sending a cookie to/_next/imagedoes not cause the optimizer to forward it upstream (request now fails with400).Written by Cursor Bugbot for commit 6b12c60. This will update automatically on new commits. Configure here.