Avoid proxying React modules through workUnitStore (#85486)#8
Open
MitchLewis930 wants to merge 1 commit intopr_038_beforefrom
Open
Avoid proxying React modules through workUnitStore (#85486)#8MitchLewis930 wants to merge 1 commit intopr_038_beforefrom
MitchLewis930 wants to merge 1 commit intopr_038_beforefrom
Conversation
Today the `captureOwnerStack()` function is provided to shared utilities through an AsyncLocalStorage that scopes the method from the appropriate React instance. This is so that external code like patches to sync IO methods can still generate errors with the appropriate React owner information even when the patched code itself is not bundled and can be called from etiher SSR or RSC contexts. This works but it makes plumbing the React instances around tricky. There is a simpler way. Most of the time you can just try both React's. If one gives you a non-null/undefined result then you know you are in that scope. If neither do then you're outside a React scope altogether. In this change I remove `captureOwnerStack()` from the workUnitStore types and just call it from the shared server runtime which gives even external code access to the appropriate React instances for bundled code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR_038
Note
Medium Risk
Touches global dev/runtime hooks used during prerendering (console patching and error stack augmentation); mistakes could degrade debugging output or prerender abort/dimming behavior, though runtime semantics outside dev should be largely unaffected.
Overview
Moves dev-only React integrations (console dimming and owner-stack stitching) off of
workUnitStoreand onto a new global registry (runtime-reacts.external). React instances are now registered from the app page module and consumed viagetServerReact()/getClientReact()forcacheSignal()andcaptureOwnerStack().This removes
captureOwnerStackfrom prerender work-unit store types and stops threading it through multiple prerender store constructions, updating associated tests and NFT production fixture expectations to include the new external module.Written by Cursor Bugbot for commit c0c75e4. This will update automatically on new commits. Configure here.