Fix: css in next/dynamic component in edge runtime (#64382)#1
Open
MitchLewis930 wants to merge 1 commit intopr_031_beforefrom
Open
Fix: css in next/dynamic component in edge runtime (#64382)#1MitchLewis930 wants to merge 1 commit intopr_031_beforefrom
MitchLewis930 wants to merge 1 commit intopr_031_beforefrom
Conversation
### What Wrap async local storage for all edge runtime routes in adapter Basically fixed the case reported in [this tweet](https://x.com/keegandonley/status/1778538456458854880) ### Why We're relying on the ALS for dynamic css preloading but we didn't wrap the ALS for request handlers for edge. So if you have CSS imports in `next/dynamic` in edge runtime it would break. Closes NEXT-3085
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where CSS was not properly loading in next/dynamic components when using the edge runtime. The fix ensures that the request async storage context is available during CSS preloading in edge runtime environments.
Changes:
- Updated CSS preloading logic to properly invoke
getExpectedRequestStorewith a caller argument - Wrapped edge runtime handler execution with
RequestAsyncStorageWrapperto provide request context - Added test coverage for edge runtime dynamic CSS loading
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/e2e/app-dir/dynamic-css/index.test.ts | Added test case to verify CSS loads correctly in edge runtime |
| test/e2e/app-dir/dynamic-css/app/ssr/edge/page.js | Created new test page that uses edge runtime |
| packages/next/src/shared/lib/lazy-dynamic/preload-css.tsx | Fixed CSS preloading to pass caller argument to getExpectedRequestStore |
| packages/next/src/server/web/adapter.ts | Wrapped handler execution with request async storage context |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| `window.getComputedStyle(document.querySelector('.text')).color` | ||
| ) | ||
| ).toBe('rgb(255, 0, 0)') | ||
| // Default border width, which is not effected by bar.css that is not loaded in /ssr |
There was a problem hiding this comment.
Corrected spelling of 'effected' to 'affected'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR_031