Fix: css in next/dynamic component in edge runtime (#64382)#1
Open
MitchLewis930 wants to merge 1 commit intopr_031_beforefrom
Open
Fix: css in next/dynamic component in edge runtime (#64382)#1MitchLewis930 wants to merge 1 commit intopr_031_beforefrom
MitchLewis930 wants to merge 1 commit intopr_031_beforefrom
Conversation
### What Wrap async local storage for all edge runtime routes in adapter Basically fixed the case reported in [this tweet](https://x.com/keegandonley/status/1778538456458854880) ### Why We're relying on the ALS for dynamic css preloading but we didn't wrap the ALS for request handlers for edge. So if you have CSS imports in `next/dynamic` in edge runtime it would break. Closes NEXT-3085
Greptile OverviewGreptile SummaryFixed CSS preloading issue for Key Changes:
Impact: Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Client
participant Adapter as Edge Runtime Adapter
participant ALS as RequestAsyncStorage
participant Handler as Route Handler
participant PreloadCSS as PreloadCss Component
participant Manifest as ReactLoadableManifest
Client->>Adapter: Request to edge route
Adapter->>Adapter: Create NextRequest
Adapter->>ALS: RequestAsyncStorageWrapper.wrap()
activate ALS
Note over ALS: Initialize RequestStore with<br/>req, reactLoadableManifest, assetPrefix
ALS->>Handler: Execute params.handler(request, event)
Handler->>PreloadCSS: Render component with next/dynamic
PreloadCSS->>PreloadCSS: Check typeof window !== 'undefined'
PreloadCSS->>ALS: getExpectedRequestStore('next/dynamic css')
ALS-->>PreloadCSS: Return requestStore
PreloadCSS->>Manifest: Access requestStore.reactLoadableManifest
Manifest-->>PreloadCSS: CSS files for moduleIds
PreloadCSS-->>Handler: Render link tags for CSS preloading
Handler-->>ALS: Response
deactivate ALS
ALS-->>Adapter: Response
Adapter-->>Client: Response with CSS preload links
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR_031