Include frameworks in main-app (#41465)

[MitchLewis930]

PR_033

[greptile-apps]

Greptile Overview

Greptile Summary

Modified webpack splitChunks configuration to bundle framework dependencies (React/ReactDOM) directly into main-app chunk for app directory builds instead of creating a separate framework chunk. This optimization reduces the number of chunks and eliminates duplication since app directory entries already include these dependencies.

Key changes:

• Added main-app to the list of excluded chunks in the main chunks filter
• Changed framework cacheGroup's chunks property from 'all' to a conditional function
• When hasAppDir is true, the function excludes main-app, app-internals, and chunks starting with app/ from the framework chunk extraction
• For non-app chunks (pages directory), framework dependencies continue to be extracted as before

Confidence Score: 5/5

• This PR is safe to merge with minimal risk
• The change is well-scoped and addresses a specific optimization for webpack chunk splitting. The logic is clear and properly guards the new behavior with the hasAppDir condition, ensuring backward compatibility for pages directory builds. The modification only affects how framework dependencies are bundled for app directory entries, which is an internal optimization that shouldn't break existing functionality.
• No files require special attention

Important Files Changed

Filename	Overview
packages/next/build/webpack-config.ts	Modified webpack splitChunks configuration to include framework dependencies in main-app chunk instead of creating separate framework chunk

Sequence Diagram

sequenceDiagram
    participant WC as Webpack Config
    participant SC as SplitChunks Plugin
    participant FC as Framework CacheGroup
    participant Chunks as Chunk Output
    
    WC->>SC: Configure splitChunks optimization
    SC->>SC: Evaluate chunks function
    SC->>SC: Exclude polyfills, main, main-app, pages/_app
    
    alt hasAppDir is true
        SC->>FC: Evaluate framework cacheGroup
        FC->>FC: Check chunk name
        alt chunk is main-app, app-internals, or app/*
            FC->>FC: Return false (exclude from framework chunk)
            FC->>Chunks: Include in main-app bundle
        else chunk is not app-related
            FC->>FC: Return true (include in framework chunk)
            FC->>Chunks: Extract to separate framework chunk
        end
    else hasAppDir is false
        SC->>FC: Use all chunks for framework
        FC->>Chunks: Extract all framework deps to separate chunk
    end

Loading

[greptile-apps]

_{1 file reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}