Fixup code for use with rackup gem (may be used with rack 3) (#3061)#10
Open
MitchLewis930 wants to merge 1 commit intopr_060_beforefrom
Open
Fixup code for use with rackup gem (may be used with rack 3) (#3061)#10MitchLewis930 wants to merge 1 commit intopr_060_beforefrom
MitchLewis930 wants to merge 1 commit intopr_060_beforefrom
Conversation
* Fixup code for use with rackup gem (may be used with rack 3) * Update rack_default.rb * Update puma.rb, use `include` instead of `module_eval` * Changes per comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR_060
Note
Medium Risk
Touches server boot/handler registration and default selection logic across Rack 2 vs Rack 3, so mis-detection or constant-loading differences could break app startup in some environments.
Overview
Updates Puma’s Rack handler integration to support Rack 3’s extraction of
rackup.When
Rackupis present, Puma now defines/registers its handler underRackup::Handlerand uses it for the default handler selection; for Rack < 3 it continues to useRack::Handler, and it raises a clear error if Rack 3 is used withoutrackup. Tests are updated to run against eitherrackorrackupbased onPUMA_CI_RACK_2, and the Gemfile conditionally adds therackupdependency for non-Rack-2 CI runs.Written by Cursor Bugbot for commit 8092bf8. This will update automatically on new commits. Configure here.