fix access priorities of each level in LeveledOptions (#1118)#6
Open
MitchLewis930 wants to merge 1 commit intopr_056_beforefrom
Open
fix access priorities of each level in LeveledOptions (#1118)#6MitchLewis930 wants to merge 1 commit intopr_056_beforefrom
MitchLewis930 wants to merge 1 commit intopr_056_beforefrom
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
|
|
||
| def [](key) | ||
| @set.each do |o| | ||
| @set.reverse_each do |o| |
There was a problem hiding this comment.
flatten method uses inconsistent priority after [] change
Medium Severity
The [] method now uses reverse_each to give later levels higher priority (last wins), but the flatten method still uses forward @set.each with ||=, which gives earlier levels higher priority (first wins). This causes options[:key] and options.flatten[:key] to return different values when the same key exists in multiple levels, breaking consistency when flatten! is called.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


PR_056
Note
Low Risk
Small change to configuration option lookup order plus a targeted test; low risk but could affect how conflicting config values are resolved.
Overview
Fixes option resolution in
LeveledOptions#[]so lookups prefer the most recently shifted/loaded option level (iterates@setin reverse), ensuring later config layers override earlier ones.Adds a regression test verifying
workersset via the DSL can be mutated/overwritten afterloadwithout being masked by earlier option layers.Written by Cursor Bugbot for commit 8509829. This will update automatically on new commits. Configure here.