[Fix #3228] idle-timeout not working in cluster mode (#3235)#7
Open
MitchLewis930 wants to merge 1 commit intopr_057_beforefrom
Open
[Fix #3228] idle-timeout not working in cluster mode (#3235)#7MitchLewis930 wants to merge 1 commit intopr_057_beforefrom
idle-timeout not working in cluster mode (#3235)#7MitchLewis930 wants to merge 1 commit intopr_057_beforefrom
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| # exiting until any background operations are completed | ||
| @config.run_hooks(:before_worker_shutdown, index, @log_writer, @hook_data) | ||
|
|
||
| Process.kill "SIGTERM", master if server.idle_timeout_reached |
There was a problem hiding this comment.
Missing exception handling for dead master process signal
Low Severity
The Process.kill "SIGTERM", master call lacks exception handling for Errno::ESRCH, which is raised when the target process no longer exists. If the master process dies between the check_pipe detection and this line (a narrow race window), an unhandled exception occurs. The rest of the codebase consistently handles this exception for Process.kill calls (e.g., in worker_handle.rb). Adding rescue Errno::ESRCH would align with existing patterns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


PR_057
Note
Medium Risk
Touches server accept-loop shutdown behavior and introduces a new worker-to-master
SIGTERMpath, which could affect shutdown/restart semantics if idle timeouts are misdetected.Overview
Fixes
idle_timeoutbehavior in cluster mode by havingPuma::Serverrecord when an idle timeout stops the accept loop (idle_timeout_reached), and having cluster workers propagate that event by sendingSIGTERMto the master so the whole cluster shuts down.Adds integration coverage for
idle_timeoutin both single and cluster modes, and includes a small typo fix in a comment inrunner.rb.Written by Cursor Bugbot for commit 8d1f77b. This will update automatically on new commits. Configure here.