Ensure and enforce that configs are loaded before options are accesse…#8
Open
MitchLewis930 wants to merge 1 commit intopr_058_beforefrom
Open
Ensure and enforce that configs are loaded before options are accesse…#8MitchLewis930 wants to merge 1 commit intopr_058_beforefrom
MitchLewis930 wants to merge 1 commit intopr_058_beforefrom
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
|
|
||
| @status = :run | ||
|
|
||
| log_config if env['PUMA_LOG_CONFIG'] |
There was a problem hiding this comment.
Duplicate warnings printed when clamp called twice
Medium Severity
The clamp method is called twice in Launcher: once in initialize (line 54) and again in run (line 194). Since clamp calls warn_hooks each time without any guard against duplicate execution, cluster-only hook warnings will be printed twice to the console, confusing users with duplicate messages.
Additional Locations (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


PR_058
Note
Medium Risk
Touches core boot/configuration and hook execution paths; mistakes could prevent Puma from starting or cause hooks/defaults to behave differently, though changes are largely lifecycle enforcement with updated tests.
Overview
Configuration lifecycle is now enforced.
Puma::Configuration#optionsraises unlessclamphas been called,config_filesraises unlessloadhas been called, andclampnow implicitly callsloadthen finalizes defaults.Config consumers are updated to the new contract.
Launcher,ControlCLI, benchmark tooling, Rack handler tests, and other call sites switch fromload/direct option mutation to callingclampand then readingoptions.Hook handling is reworked. Fork/cluster-only hooks are stored as structured entries (
block/id/cluster_only), warnings about cluster-only hooks in single mode move from the DSL toConfiguration#clamp, and lifecycle events are accessed viaconfig.events.Binder initialization is decoupled from
Configuration.Bindernow takes an options hash (and uses it for rack env + SSL store extraction), with all call sites updated accordingly.Written by Cursor Bugbot for commit b16790f. This will update automatically on new commits. Configure here.