Skip to content

[Fix #3228] idle-timeout not working in cluster mode (#3235)#7

Open
MitchLewis930 wants to merge 1 commit intopr_057_beforefrom
pr_057_after
Open

[Fix #3228] idle-timeout not working in cluster mode (#3235)#7
MitchLewis930 wants to merge 1 commit intopr_057_beforefrom
pr_057_after

Conversation

@MitchLewis930
Copy link

PR_057

@MitchLewis930 MitchLewis930 requested a review from Copilot January 31, 2026 01:34
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the idle-timeout functionality in cluster mode by ensuring the master process is terminated when idle timeout is reached in worker processes.

Changes:

  • Added idle_timeout_reached flag tracking to the Server class
  • Modified worker shutdown logic to signal master process termination on idle timeout
  • Added integration tests for both single and cluster modes to verify idle timeout behavior

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
lib/puma/server.rb Added idle_timeout_reached attribute and flag setting logic when idle timeout occurs
lib/puma/cluster/worker.rb Added logic to send SIGTERM to master process when worker detects idle timeout
test/test_integration_single.rb Added test case to verify idle timeout works in single mode
test/test_integration_cluster.rb Added test case to verify idle timeout works in cluster mode
lib/puma/runner.rb Fixed typo in comment from "aand" to "and"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants