[Fix #3228] idle-timeout not working in cluster mode (#3235)#7
Open
MitchLewis930 wants to merge 1 commit intopr_057_beforefrom
Open
[Fix #3228] idle-timeout not working in cluster mode (#3235)#7MitchLewis930 wants to merge 1 commit intopr_057_beforefrom
idle-timeout not working in cluster mode (#3235)#7MitchLewis930 wants to merge 1 commit intopr_057_beforefrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes the idle-timeout functionality in cluster mode by ensuring the master process is terminated when idle timeout is reached in worker processes.
Changes:
- Added
idle_timeout_reachedflag tracking to the Server class - Modified worker shutdown logic to signal master process termination on idle timeout
- Added integration tests for both single and cluster modes to verify idle timeout behavior
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lib/puma/server.rb | Added idle_timeout_reached attribute and flag setting logic when idle timeout occurs |
| lib/puma/cluster/worker.rb | Added logic to send SIGTERM to master process when worker detects idle timeout |
| test/test_integration_single.rb | Added test case to verify idle timeout works in single mode |
| test/test_integration_cluster.rb | Added test case to verify idle timeout works in cluster mode |
| lib/puma/runner.rb | Fixed typo in comment from "aand" to "and" |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR_057