Skip to content

Conversation

@stanminlee
Copy link

@stanminlee stanminlee commented Jan 9, 2026

Paths did not include the top module, so it is added now


Important

Add top module name to hierarchical path for generated clocks in Sdc.cc and update related test files.

  • Behavior:
    • Add top module name to hierarchical path in createLibertyGeneratedClocks() in Sdc.cc.
    • Update generated clock paths in generated_clock.ok to include generated_clock/ prefix.
    • Modify generated_clock.tcl to use updated clock paths.
  • Tests:
    • Update expected output in generated_clock.ok to reflect new clock paths.
    • Adjust generated_clock.tcl to validate new clock paths.

This description was created by Ellipsis for d2ed1db. You can customize this summary. It will automatically update as commits are pushed.

@stanminlee stanminlee marked this pull request as ready for review January 9, 2026 02:36
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to d2ed1db in 43 seconds. Click for details.
  • Reviewed 85 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. test/generated_clock.ok:1
  • Draft comment:
    The expected output now shows full hierarchical names (e.g. 'generated_clock/u_second_hierarchy/clk_gen/CLK_OUT_DIV'), which is consistent with the new naming convention. This file appears updated correctly.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
2. test/generated_clock.tcl:15
  • Draft comment:
    The TCL script now uses the full hierarchical names (e.g. '-master_clock generated_clock/clk_edge_shift/CLK_OUT') to create generated clocks. The comments and commands reflect the updated scheme correctly.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_mhFMBDZtE8bs4cwD

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@stanminlee stanminlee marked this pull request as draft January 9, 2026 18:50
@stanminlee stanminlee marked this pull request as ready for review January 9, 2026 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants