Implement photo picker#63
Open
Rajan-p-simform wants to merge 2 commits intoSimformSolutionsPvtLtd:developfrom
Open
Implement photo picker#63Rajan-p-simform wants to merge 2 commits intoSimformSolutionsPvtLtd:developfrom
Rajan-p-simform wants to merge 2 commits intoSimformSolutionsPvtLtd:developfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades Android SDK and Gradle tooling, replaces Kotlin synthetic views with view binding, and implements modern media picker APIs alongside utility methods for file handling.
- Bumped Gradle, compile/target SDK versions, dependencies, enabled viewBinding
- Replaced
kotlinx.android.syntheticusages with generatedBindingclasses - Added
ActivityResultContractsfile pickers andCommonhelpers for URI-to-path conversion
Reviewed Changes
Copilot reviewed 40 out of 41 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| gradle/wrapper/gradle-wrapper.properties | Updated Gradle distribution to 8.5 |
| app/build.gradle | Migrated to viewBinding, bumped compileSdk/targetSdk to 35 |
| app/src/main/java/com/simform/videoimageeditor/BaseActivity.kt | Registered PickVisualMedia contracts for single/multiple picks |
| SSffmpegVideoOperation/src/main/java/com/simform/videooperations/Common.kt | Added saveFileToTempAndGetPath, getDurationFromFile, updated file path logic |
| app/src/main/java/com/simform/videoimageeditor/videoProcessActivity/CombineVideosActivity.kt | Updated picker logic for multiple media and binding refs |
| app/src/main/res/values/strings.xml | Added time picker strings |
| app/src/main/AndroidManifest.xml | Adjusted external storage permissions |
Comments suppressed due to low confidence (1)
app/src/main/res/values/strings.xml:114
- XML resource files do not support //–style comments; this line will break the XML parser. Wrap comments in instead.
// Time Picker
app/src/main/java/com/simform/videoimageeditor/videoProcessActivity/CombineVideosActivity.kt
Outdated
Show resolved
Hide resolved
SSffmpegVideoOperation/src/main/java/com/simform/videooperations/Common.kt
Show resolved
Hide resolved
0e2605d to
27ad481
Compare
27ad481 to
857bda5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant updates to the Android project, including upgrading dependencies, enhancing compatibility with newer Android SDKs, and implementing modern features like view binding and media picker APIs. The most important changes are grouped into dependency updates, SDK compatibility enhancements, and feature additions.
Dependency Updates:
SSffmpegVideoOperation/build.gradleandapp/build.gradleto newer versions, includingandroidx.core:core-ktx(1.9.0),androidx.appcompat:appcompat(1.7.1), andcom.google.android.material:material(1.12.0). [1] [2]Feature Additions:
ActivityResultContracts.PickVisualMediaandActivityResultContracts.PickMultipleVisualMedia) inBaseActivity.ktfor modern file selection workflows. [1] [2]Common.ktfor handling file paths, saving temporary files, and retrieving media duration. [1] [2] [[3]]