Update image to video query#64
Open
Rajan-p-simform wants to merge 3 commits intoSimformSolutionsPvtLtd:developfrom
Open
Update image to video query#64Rajan-p-simform wants to merge 3 commits intoSimformSolutionsPvtLtd:developfrom
Rajan-p-simform wants to merge 3 commits intoSimformSolutionsPvtLtd:developfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the FFmpeg image-to-video conversion to enforce even dimensions and modernizes media picking across the app for Android 13+.
- Enforce even width/height in
imageToVideoqueries to avoid codec errors. - Replace Kotlin synthetic view access with ViewBinding and migrate to ActivityResultContracts for media selection.
- Update
Common.getFilePathfor API 33+ storage handling, add helper methods for URI-based file access.
Reviewed Changes
Copilot reviewed 41 out of 42 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| SSffmpegVideoOperation/src/main/java/com/simform/videooperations/FFmpegQueryExtension.kt | Ensure width and height are even in the image-to-video conversion. |
| SSffmpegVideoOperation/src/main/java/com/simform/videooperations/Common.kt | Adapt output paths for Android 13+, add URI→file temp helper, duration retrieval. |
| app/src/main/res/values/strings.xml | Added time-picker strings and an inline comment. |
| app/src/main/AndroidManifest.xml | Updated READ_EXTERNAL_STORAGE permission with maxSdkVersion. |
Comments suppressed due to low confidence (2)
app/src/main/res/values/strings.xml:114
- XML resource comments should use syntax instead of //. The line '// Time Picker' will break resource parsing.
// Time Picker
app/src/main/AndroidManifest.xml:7
- The 'tools:ignore' attribute is used without declaring the 'xmlns:tools' namespace. Add xmlns:tools to the element to avoid manifest merge errors.
<uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE"
SSffmpegVideoOperation/src/main/java/com/simform/videooperations/Common.kt
Outdated
Show resolved
Hide resolved
10dbec7 to
4b7e490
Compare
4b7e490 to
353a2f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Image to Video Conversion Query
This PR updates the FFmpeg query used for converting static images to video. The enhancement manages the failure case when the image's height and width are not even.
Changes
Modified the imageToVideo method in FFmpegQueryExtension to ensure width and height values are always even numbers, which prevents codec compatibility issues
Updated the audio Pick code to support latest android versions