Support edge to edge#66
Open
Rajan-p-simform wants to merge 5 commits intoSimformSolutionsPvtLtd:developfrom
Open
Support edge to edge#66Rajan-p-simform wants to merge 5 commits intoSimformSolutionsPvtLtd:developfrom
Rajan-p-simform wants to merge 5 commits intoSimformSolutionsPvtLtd:developfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds edge-to-edge support across the app by migrating to view binding, introducing a reusable toolbar component, and updating themes and layouts to remove the action bar and position views under the toolbar. It also upgrades build settings (JDK, Gradle) and adds time-picker resources.
- Upgrade JDK to openjdk8 and Gradle wrapper to 8.5; suppress unsupported compileSdk warning
- Change MaterialComponents theme parent to NoActionBar and add a
ToolbarTitleTextAppearancestyle - Introduce
enableEdgeToEdgeextension, migrate activities to view binding, and include atoolbar_appin all layouts
Reviewed Changes
Copilot reviewed 77 out of 79 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| jitpack.yml | Added openjdk8 to JDK matrix |
| gradle/wrapper/gradle-wrapper.properties | Updated Gradle distribution to 8.5-bin.zip |
| app/src/main/res/values/themes.xml | Switched base theme to NoActionBar |
| app/src/main/java/com/simform/videoimageeditor/utils/ExtensionsUtils.kt | Added enableEdgeToEdge extension method |
| app/src/main/res/layout/toolbar_app.xml | New reusable AppBarLayout/MaterialToolbar layout |
| app/src/main/res/values/strings.xml | Added strings for time picker |
| app/src/main/java/com/simform/videoimageeditor/middlewareActivity/VideoProcessActivity.kt | Migrated to view binding and edge-to-edge |
Comments suppressed due to low confidence (4)
app/src/main/res/values/strings.xml:119
- [nitpick] The string resource ID
titleis very generic and may collide with other resources or Android attributes. Consider renaming it to a more specific key, e.g.toolbar_title.
<string name="title">title</string>
app/src/main/res/values/strings.xml:114
- XML resource files don’t support
//comments. Replace this with a proper XML comment (<!-- Time Picker -->) or remove the line.
// Time Picker
app/src/main/java/com/simform/videoimageeditor/videoProcessActivity/CutVideoUsingTimeActivity.kt:9
- There is no
enableEdgeToEdgeinandroidx.activity. Remove this import and keep only the utility import fromcom.simform.videoimageeditor.utils.
import androidx.activity.enableEdgeToEdge
app/src/main/java/com/simform/videoimageeditor/videoProcessActivity/CompressVideoActivity.kt:8
- Incorrect import of
enableEdgeToEdge; remove this and use the extension fromcom.simform.videoimageeditor.utils.
import androidx.activity.enableEdgeToEdge
616bfc2 to
32b4203
Compare
6807460 to
966ee7e
Compare
966ee7e to
c8fefeb
Compare
c8fefeb to
3490a0b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support edge to edge for latest android devices