Combine image and video leads to more than 1000 frame duplication.#68
Open
Rajan-p-simform wants to merge 7 commits intoSimformSolutionsPvtLtd:developfrom
Open
Conversation
Rajan-p-simform
commented
Jul 7, 2025
- Update query to limit the frame dublication
There was a problem hiding this comment.
Pull Request Overview
This PR updates project configuration, migrates activities and layouts to use ViewBinding with an edge-to-edge helper, and adds a custom time picker widget with associated resources.
- Upgrade build environment and Android settings (JDK versions, Gradle wrapper, compile SDK suppression)
- Migrate all Activities to ViewBinding and apply edge-to-edge Insets via
enableEdgeToEdge - Introduce a reusable toolbar, string entries for time picker, and a custom TimePicker widget/dialog
Reviewed Changes
Copilot reviewed 79 out of 81 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| jitpack.yml | Add OpenJDK 8 to supported JDKs |
| gradle/wrapper/gradle-wrapper.properties | Bump Gradle distribution to 8.5 |
| gradle.properties | Suppress unsupported compile SDK warning |
| app/src/main/res/values/strings.xml | Add time-picker strings and toolbar title |
| app/src/main/res/layout/toolbar_app.xml | New shared toolbar layout |
| app/src/main/res/layout/time_picker_*.xml | Add TimePicker widget and dialog layouts |
| app/src/main/java/.../utils/ExtensionsUtils.kt | Edge-to-edge insets extension |
| app/src/main/java/.../middlewareActivity/*Activity.kt | Migrate to ViewBinding & edge-to-edge |
| app/src/main/java/.../videoProcessActivity/*Activity.kt | Migrate to ViewBinding, add Android 14 media pickers |
Comments suppressed due to low confidence (3)
app/src/main/res/values/strings.xml:114
- XML does not support '//' comments—this will break resource parsing. Wrap that note in instead.
// Time Picker
app/src/main/java/com/simform/videoimageeditor/videoProcessActivity/CutVideoUsingTimeActivity.kt:9
- This import is incorrect and will not resolve. You should import the
enableEdgeToEdgeextension fromcom.simform.videoimageeditor.utils.
import androidx.activity.enableEdgeToEdge
app/src/main/java/com/simform/videoimageeditor/middlewareActivity/OtherFFMPEGProcessActivity.kt:4
- Duplicate/wrong extension import—remove this
androidx.activity.enableEdgeToEdgeimport and rely oncom.simform.videoimageeditor.utils.enableEdgeToEdgeonly.
import androidx.activity.enableEdgeToEdge
0760507 to
13b93f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.