Provide options to choose watermark positions.#69
Open
Rajan-p-simform wants to merge 8 commits intoSimformSolutionsPvtLtd:developfrom
Open
Provide options to choose watermark positions.#69Rajan-p-simform wants to merge 8 commits intoSimformSolutionsPvtLtd:developfrom
Rajan-p-simform wants to merge 8 commits intoSimformSolutionsPvtLtd:developfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds configurable watermark positioning and modernizes UI components across activities.
- Introduce a spinner in AddWaterMarkOnVideoActivity to select watermark position (custom, center, fill, crop, corners).
- Update AddWaterMarkOnVideoActivity logic to pass the chosen position or custom X/Y coordinates to the FFmpeg query.
- Migrate from Kotlin synthetics to view binding, add a common toolbar include, and enable edge-to-edge layouts.
Reviewed Changes
Copilot reviewed 79 out of 81 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| app/src/main/res/layout/activity_add_water_mark_on_video.xml | Added spinner for watermark position options. |
| app/src/main/java/com/simform/videoimageeditor/.../AddWaterMarkOnVideoActivity.kt | Setup spinner and pass position params to the query. |
| app/src/main/res/layout/toolbar_app.xml | New reusable MaterialToolbar layout. |
| app/src/main/java/com/simform/videoimageeditor/utils/ExtensionsUtils.kt | Added enableEdgeToEdge extension for activities. |
| app/src/main/res/values/themes.xml | Switched to NoActionBar to support custom toolbar. |
Comments suppressed due to low confidence (3)
app/src/main/res/values/strings.xml:114
- XML resource files should use XML comments (
<!-- ... -->) instead of//. Replace this line with an XML comment or remove it.
// Time Picker
app/src/main/res/layout/time_picker_widget.xml:18
- This line appears to be a stray Java comment terminator inside XML. Remove or wrap the license header in valid XML comments.
*/
app/src/main/res/layout/activity_change_audio_valume.xml:1
- [nitpick] The file and binding class use
valumeinstead ofvolume; consider renaming toactivity_change_audio_volume.xmland updating the corresponding binding.
<?xml version="1.0" encoding="utf-8"?>
...src/main/java/com/simform/videoimageeditor/videoProcessActivity/CutVideoUsingTimeActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/simform/videoimageeditor/videoProcessActivity/CompressVideoActivity.kt
Outdated
Show resolved
Hide resolved
dcfb261 to
acc755b
Compare
acc755b to
fdab622
Compare
fdab622 to
6735566
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide options to choose watermark positions.
eg. center, fill, crop, top-left, top-right, bottom-left, bottom-right