Optimise video compress query#70
Open
Rajan-p-simform wants to merge 9 commits intoSimformSolutionsPvtLtd:developfrom
Open
Optimise video compress query#70Rajan-p-simform wants to merge 9 commits intoSimformSolutionsPvtLtd:developfrom
Rajan-p-simform wants to merge 9 commits intoSimformSolutionsPvtLtd:developfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the build configuration, refactors UI layouts with a common toolbar, and migrates activities to view binding and modern media pickers.
- Upgrade JDK/Gradle versions in CI and wrapper
- Add a reusable toolbar layout and adjust themes
- Migrate activities from synthetic imports to ViewBinding, ActivityResultContracts, and edge-to-edge support
Reviewed Changes
Copilot reviewed 79 out of 81 changed files in this pull request and generated 1 comment.
Show a summary per file
| File(s) | Description |
|---|---|
| jitpack.yml | Added OpenJDK 8 alongside OpenJDK 11 for build compatibility |
| gradle/wrapper/gradle-wrapper.properties | Upgraded Gradle distribution to version 8.5 |
| app/src/main/res/values/themes.xml | Switched to NoActionBar theme and added ToolbarTitleTextAppearance |
| app/src/main/res/values/strings.xml | Added strings for time picker (note: invalid comment syntax) |
| app/src/main/res/layout/toolbar_app.xml & other layouts | Introduced a shared toolbar include and updated Constraint layouts |
app/src/main/java/**Activity.kt (all Activity classes) |
Migrated to ViewBinding, ActivityResultContracts, and edge-to-edge |
Comments suppressed due to low confidence (5)
app/src/main/res/values/strings.xml:114
- XML resource files do not support
//comments. Replace this with a proper XML comment, e.g.<!-- Time Picker -->.
// Time Picker
app/src/main/java/com/simform/videoimageeditor/videoProcessActivity/CutVideoUsingTimeActivity.kt:9
- This import is invalid. You should import your extension from
com.simform.videoimageeditor.utils.enableEdgeToEdgeinstead ofandroidx.activity.enableEdgeToEdge.
import androidx.activity.enableEdgeToEdge
app/src/main/java/com/simform/videoimageeditor/videoProcessActivity/CompressVideoActivity.kt:8
- Replace this with
import com.simform.videoimageeditor.utils.enableEdgeToEdgeto pull in the correct extension function.
import androidx.activity.enableEdgeToEdge
app/src/main/java/com/simform/videoimageeditor/MainActivity.kt:4
- Import the
enableEdgeToEdgeextension from your utils package:com.simform.videoimageeditor.utils.enableEdgeToEdge.
import androidx.activity.enableEdgeToEdge
app/src/main/java/com/simform/videoimageeditor/middlewareActivity/OtherFFMPEGProcessActivity.kt:4
- This import points to a nonexistent symbol. Use
com.simform.videoimageeditor.utils.enableEdgeToEdgeinstead.
import androidx.activity.enableEdgeToEdge
0e8d55e to
740f76e
Compare
740f76e to
dda80c3
Compare
dda80c3 to
f5f5024
Compare
- Reduce size and provide better quality output video
f5f5024 to
28d62e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimise video compress query