Add encoding quality option to video processing functions#71
Open
Rajan-p-simform wants to merge 10 commits intoSimformSolutionsPvtLtd:developfrom
Open
Add encoding quality option to video processing functions#71Rajan-p-simform wants to merge 10 commits intoSimformSolutionsPvtLtd:developfrom
Rajan-p-simform wants to merge 10 commits intoSimformSolutionsPvtLtd:developfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds an encoding quality parameter to all video/audio processing calls (defaulting to FASTEST), migrates activities to ViewBinding with edge-to-edge support, and updates UI layouts (including a reusable toolbar and a watermark-position spinner).
- Introduce
EncodingQualityargument in FFmpeg queries, defaulting toFASTEST - Replace Kotlin synthetics with ViewBinding and apply
enableEdgeToEdge - Add a generic toolbar layout and a position spinner in the watermark activity
Reviewed Changes
Copilot reviewed 80 out of 82 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| jitpack.yml | Adds support for OpenJDK 8 |
| gradle/wrapper/gradle-wrapper.properties | Upgrades Gradle distribution to 8.5 |
| app/src/main/res/values/strings.xml | Adds time-picker strings (invalid XML comment present) |
| app/src/main/res/layout/toolbar_app.xml | New reusable toolbar layout |
| app/src/main/java/.../VideoToGifActivity.kt | Migrates to ViewBinding and adds EncodingQuality param |
Comments suppressed due to low confidence (4)
app/src/main/java/com/simform/videoimageeditor/videoProcessActivity/VideoToGifActivity.kt:61
- New encodingQuality behavior is introduced here; consider adding unit or integration tests to verify that FASTEST, BALANCED, and HIGHEST modes produce expected outputs.
val query = ffmpegQueryExtension.convertVideoToGIF(binding.tvInputPathVideo.text.toString(), outputPath, EncodingQuality.FASTEST)
app/src/main/java/com/simform/videoimageeditor/videoProcessActivity/VideoToGifActivity.kt:61
- EncodingQuality is hardcoded to FASTEST with no UI to choose other modes; consider exposing a setting or parameter so users can select BALANCED or HIGHEST.
val query = ffmpegQueryExtension.convertVideoToGIF(binding.tvInputPathVideo.text.toString(), outputPath, EncodingQuality.FASTEST)
app/src/main/res/values/strings.xml:114
- XML comments must use syntax rather than //; this line will cause a resource parsing error.
// Time Picker
app/src/main/res/layout/activity_change_audio_valume.xml:1
- Filename and binding class contain a typo: 'valume' should be 'volume' for consistency.
<?xml version="1.0" encoding="utf-8"?>
app/src/main/java/com/simform/videoimageeditor/videoProcessActivity/VideoRotateFlipActivity.kt
Outdated
Show resolved
Hide resolved
d1a98f5 to
a24f3f3
Compare
a24f3f3 to
ec55006
Compare
- Reduce size and provide better quality output video
ec55006 to
c7fb67e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Developers can now choose the preferred performance mode for video operations, balancing between speed and output quality.
We offer three modes:
FASTEST – Optimized for speed; operations complete quickly but may result in lower output quality.
BALANCED – Offers a middle ground between processing time and quality.
HIGHEST – Prioritizes output quality; operations may take longer to complete.
This flexibility allows developers to adjust performance based on their specific use case.