-
Notifications
You must be signed in to change notification settings - Fork 7
Task: allow dimensions to be parsed to the noderedirect finisher #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hphoeksma
wants to merge
31
commits into
SimplyAdmire:master
Choose a base branch
from
UpAssist:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allowing dimensions to the NodeRedirectFinisher makes it possible to parse in language
prefixes, i.e.:
```
options:
nodePath: /sites/mysitecom/node-566a9d076f97e/node-582f0570dfec4
dimensions:
language:
- en
```
Reworking the contentContext initialization make sure the proper path is being set.
Adjust to the major changes in FLOW3 1.1 when coming from 1.0. Note: This migration did not produce any changes, so the commit simply marks the migration as applied. This makes sure it will not be applied again.
Rename form.textbox to form.textfield Note: This migration did not produce any changes, so the commit simply marks the migration as applied. This makes sure it will not be applied again.
Replace FileTypes use with MediaTypes use. Note: This migration did not produce any changes, so the commit simply marks the migration as applied. This makes sure it will not be applied again.
Replace DataNotSerializeableException with DataNotSerializableException. Note: This migration did not produce any changes, so the commit simply marks the migration as applied. This makes sure it will not be applied again.
Move all code to PSR-0 compatible directory structure, remove Package.xml, Note: This migration did not produce any changes, so the commit simply marks the migration as applied. This makes sure it will not be applied again.
Rename FLOW3 to TYPO3 Flow Note: This migration did not produce any changes, so the commit simply marks the migration as applied. This makes sure it will not be applied again.
Check for globally defined role identifiers in Policy.yaml files Note: This migration did not produce any changes, so the commit simply marks the migration as applied. This makes sure it will not be applied again.
Change entity resource definitions from using _ to \ Note: This migration did not produce any changes, so the commit simply marks the migration as applied. This makes sure it will not be applied again.
Rename "renderTypoScript" VH to just "render" Note: This migration did not produce any changes, so the commit simply marks the migration as applied. This makes sure it will not be applied again.
Rename "renderTypoScript" VH to just "render" Note: This migration did not produce any changes, so the commit simply marks the migration as applied. This makes sure it will not be applied again.
Adjust to removed TYPO3.TYPO3CR:Folder node type by replacing it Note: This migration did not produce any changes, so the commit simply marks the migration as applied. This makes sure it will not be applied again.
Change node type and TS object names in NodeTypes.yaml and PHP code. Note: This migration did not produce any changes, so the commit simply marks the migration as applied. This makes sure it will not be applied again.
Change TYPO3\Flow\Persistence\Doctrine\DatabaseConnectionException to Note: This migration did not produce any changes, so the commit simply marks the migration as applied. This makes sure it will not be applied again.
This migration does not actually change any code. It just displays a warning if a TypeConverters canConvertFrom() is Note: This migration did not produce any changes, so the commit simply marks the migration as applied. This makes sure it will not be applied again.
Adjust to updated date format for inspector date editor Note: This migration did not produce any changes, so the commit simply marks the migration as applied. This makes sure it will not be applied again.
Adjust to updated folder name for TypoScript in site packages Note: This migration did not produce any changes, so the commit simply marks the migration as applied. This makes sure it will not be applied again.
Adjust to renamed NodeLabelGeneratorInterface. Note: This migration did not produce any changes, so the commit simply marks the migration as applied. This makes sure it will not be applied again.
Migrates the former HtmlEditor to CodeEditor Note: This migration did not produce any changes, so the commit simply marks the migration as applied. This makes sure it will not be applied again.
Adjust namespaces for TYPO3CR related FlowQuery operations that were moved from TYPO3.Neos to TYPO3.TYPO3CR Note: This migration did not produce any changes, so the commit simply marks the migration as applied. This makes sure it will not be applied again.
Rename setting TYPO3.Neos.modules.<moduleName>.resource to "privilegeTarget" Note: This migration did not produce any changes, so the commit simply marks the migration as applied. This makes sure it will not be applied again.
Rename the "resource" argument of the security.ifAccess ViewHelper to "privilegeTarget" Note: This migration did not produce any changes, so the commit simply marks the migration as applied. This makes sure it will not be applied again.
Adjust "Policy.yaml" to new syntax Note: This migration did not produce any changes, so the commit simply marks the migration as applied. This makes sure it will not be applied again.
Warn about removed ReflectionService dependency from AbstractViewHelper Note: This migration did not produce any changes, so the commit simply marks the migration as applied. This makes sure it will not be applied again.
Rename node property type 'date' to DateTime Note: This migration did not produce any changes, so the commit simply marks the migration as applied. This makes sure it will not be applied again.
Add "escapeOutput" property to existing ViewHelpers to ensure backwards-compatibility Note: This migration did not produce any changes, so the commit simply marks the migration as applied. This makes sure it will not be applied again.
Migrates ImageVariant to ImageInterface Note: This migration did not produce any changes, so the commit simply marks the migration as applied. This makes sure it will not be applied again.
Migrates to new super type syntax in node type configuration Note: This migration did not produce any changes, so the commit simply marks the migration as applied. This makes sure it will not be applied again.
Adjust "Settings.yaml" to new "requestPattern" and "firewall" syntax (see FLOW-412) Note: This migration did not produce any changes, so the commit simply marks the migration as applied. This makes sure it will not be applied again.
Contributor
|
@hphoeksma did you mean to update this PR with the migrations? The upgrade is also pushed to #10 , so would prefer if this PR would be cleaned up. If you need those together in the same branch for your projects I'd prefer using a fork |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing dimensions to the NodeRedirectFinisher makes it possible to parse in language
prefixes, i.e.:
Reworking the contentContext initialization make sure the proper path is being set.